Merged
Conversation
Member
|
Thanks, merged. I agree with the mapping in this PR, no deprecation warning necessary I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "non-negative Garrote" threshold mode was misspelled "Garotte" instead of "Garrote" in some places. This PR fixes these.
(see https://www.jstor.org/stable/1269730 as a reference for Garrote being the correct spelling)
Unfortunately, one of these was in the
modeargument topywt.threshold. To avoid breaking any existing code, In this PR I chose to just allow either spelling (mode='garrote'or'mode='garotte') to be used but to only document the correct spelling in the docstring. If desired, I could add a deprecation warning for the incorrectly spelled variant.